Bug List

Class userlist

There are two private fields [u->private and u->priv] one need to be removed.

Global cmd_test_mem

Need cleanup/rewritting

Global ekg_debug_handler

It can happen than internal string_t line will be not freed.

Global session_remove

Possible implementation/idea bug in window_session_cycle() I really don't know if we should change session on this windows... Maybe swaping is ok... but we really need think about protocol.. Now If we change session from jabber to gg one this window won't be very useful..

Global window_kill

Possible bug with sort_windows. Can anyone who wrote it look at it?

Global xcalloc

same as in xmalloc()

Global xmalloc

Possible bug: Some libc may return NULL if size is 0, from man malloc:
If size is 0 (...) a null pointer (...) shall be returned.
XXX, check it in configure.ac if malloc() returns NULL on 0 size, and check here if size is 0.

Global xrealloc

same as in xmalloc()

Global gg_changed_proxy

BIG XXX, Mistake at art, it should use global config variable, not session ones, because it's used to inform libgadu about proxy servers.
And libgadu has got this variables global, not session private. Maybe we somehow can update these variables before gg_login() by callng gg_changed_proxy() but now it's BAD, BAD, BAD.

---